Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

names: link affiliations IDs from ORCiD parsing #441

Merged
merged 5 commits into from
Dec 6, 2024
Merged

names: link affiliations IDs from ORCiD parsing #441

merged 5 commits into from
Dec 6, 2024

Conversation

slint
Copy link
Member

@slint slint commented Nov 25, 2024 •
edited
Loading

@slint slint marked this pull request as draft November 25, 2024 10:09
@slint slint changed the title names orgid mapping names: link affiliations IDs from ORCiD parsing Nov 25, 2024
@slint slint force-pushed the names-orgid-mapping branch from e9c124b to 18d00e2 Compare December 4, 2024 17:03
@slint slint marked this pull request as ready for review December 4, 2024 17:04
@slint slint force-pushed the names-orgid-mapping branch from 18d00e2 to 92eabb1 Compare December 5, 2024 06:13
jrcastro2
jrcastro2 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@jrcastro2 jrcastro2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks a lot! 🚀

invenio_vocabularies/config.py Outdated Show resolved Hide resolved
invenio_vocabularies/contrib/names/datastreams.py Outdated Show resolved Hide resolved
slint added 2 commits December 5, 2024 10:59
@slint
names: support mapping affiliation IDs
53c1822 
* Allows providing a CSV file to the ORCiD transformer for mapping
  organization identifiers enountered in the ORCiD data to linkable
  affiliation IDs.
@slint
names: log errors when fetching ORCiD records
7eb9280
@slint slint force-pushed the names-orgid-mapping branch from 92eabb1 to 7eb9280 Compare December 5, 2024 10:00
@jrcastro2 jrcastro2 force-pushed the names-orgid-mapping branch 2 times, most recently from 2b7156f to 3568125 Compare December 6, 2024 09:26
@jrcastro2 jrcastro2 force-pushed the names-orgid-mapping branch from 3568125 to 6de9e81 Compare December 6, 2024 10:04
@jrcastro2 jrcastro2 merged commit b798bf3 into inveniosoftware:master Dec 6, 2024
4 checks passed
@slint slint deleted the names-orgid-mapping branch December 9, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrcastro2 jrcastro2 jrcastro2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

names: link affiliatons when parsing ORCiD entries
2 participants
@slint @jrcastro2